Vec.Properties: drop eq parameter when it is a property #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesCarette
approved these changes
Jul 5, 2024
Contributor
|
@MatthewDaggitt Is this PR ready except for the conflicts in |
Contributor
|
Yup, looks good! Thanks for the contribution! |
MatthewDaggitt
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the changes discussed in #2421 for v2.2.
Since these aren't "usual" deprecations where a lemma changes name, I've put them in a separate section at the end of the file.
Note that this conflicts with #2424, so one of those two should be merged so I have time to resolve the conflicts in the other one.